react-native-vision-camera icon indicating copy to clipboard operation
react-native-vision-camera copied to clipboard

Published 20 hours ago • verified publisher icon mrousavy

feat: Lower `minSdkVersion` from 26 to 23

Open mrousavy opened this issue 1 year ago • 4 comments

What

Lowers the minimum required SDK version from 26 to 23.

Changes

Tested on

Related issues

mrousavy avatar Jan 18 '24 17:01 mrousavy

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-vision-camera ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2024 5:32pm

vercel[bot] avatar Jan 18 '24 17:01 vercel[bot]

Thanks, we'll have no issues with this min version 👍

Julesssss avatar Jan 19 '24 09:01 Julesssss

This is going to be problematic for VisionCamera though, as multiple pieces of the codebase rely on minSdk 26:

  • VideoPipeline: The entire video pipeline will not work anymore if not running on minSdk 26. Video recordings and Frame Processing will error out then.
  • Creating a session: I need to add workarounds there as I use an API from SDK 24.
  • HDR: The entire HDR pipeline needs to be disabled on <26.

mrousavy avatar Jan 19 '24 09:01 mrousavy

Yeah, sorry to be a pain about the min-supported version.

I get that most people don't care about this and would much rather take the newer features. In our case though I'm not sure it's a trade-off worth making. I also wouldn't want us to be the sole reason for having to drop lib features, so maybe we should just seek an alternative? Let me know what you think

Julesssss avatar Jan 19 '24 10:01 Julesssss