react-native-vision-camera icon indicating copy to clipboard operation
react-native-vision-camera copied to clipboard

Published 20 hours ago • verified publisher icon mrousavy

perf: Use the truly native pixel format on iOS if available

Open mrousavy opened this issue 1 year ago • 1 comments

What

According to the videoSettings documentation, the truly native format is used when videoSettings is set to [:] - so this adds a path where this can happen (hdr is false, buffer compression is not enabled or available, and pixelFormat is native)

Not sure if this makes any difference, I think I already pick the format that is truly native for that format.

Before merging this PR, let's confirm that the pixelFormat is now different when calling CMSampleBufferGetFormatDescription(frame.buffer) in a FP Plugin.

Changes

Tested on

Related issues

mrousavy avatar Nov 22 '23 12:11 mrousavy

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-vision-camera ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2023 3:56pm

vercel[bot] avatar Nov 22 '23 12:11 vercel[bot]