react-native-vision-camera icon indicating copy to clipboard operation
react-native-vision-camera copied to clipboard

Published 20 hours ago • verified publisher icon mrousavy

fix: android build for react native 0.69

Open kantorm opened this issue 2 years ago • 6 comments

What

This PR fixes build issues on Android for React Native 0.69

Changes

* build.gradle adjustments for react-native 0.69
* CMake adjustments for react-native 0.69

Tested on

Pixel 3, Android 12, react-native 0.69 with hermes on

kantorm avatar Jul 01 '22 13:07 kantorm

when could this be merged and released?

ivi-hamiti avatar Jul 10 '22 19:07 ivi-hamiti

This PR fixes #1118, but then you get another error (issue #1125)

(For anyone looking for a quickfix: you can disable frame processors, beware you lose some functionalities like bar code scanner)

frankitox avatar Jul 13 '22 01:07 frankitox

Looking forward to this one. @blu3beri do the last changes bring it up to snuff?

spsaucier avatar Aug 03 '22 14:08 spsaucier

Looking forward to this one. @blu3beri do the last changes bring it up to snuff?

To the best of my knowledge, yes!

berendsliedrecht avatar Aug 03 '22 15:08 berendsliedrecht

Are we able to get this merged, @LucasClaude?

spsaucier avatar Aug 08 '22 17:08 spsaucier

i need this,Are we able to get this merged?

xiaohanxh avatar Aug 09 '22 05:08 xiaohanxh

These Android build issues were fixed in the PR linked just above, for others interested.

spsaucier avatar Aug 15 '22 13:08 spsaucier

@spsaucier I'm closing this one then.

kantorm avatar Aug 16 '22 12:08 kantorm