react-native-vision-camera icon indicating copy to clipboard operation
react-native-vision-camera copied to clipboard

Published 20 hours ago • verified publisher icon mrousavy

feat: Allow control of shutter sound on iOS

Open wassgha opened this issue 2 years ago • 6 comments

What

Adds functionality to control whether the shutter sound plays or not on iOS

Changes

  • Adds capture setting disableShutterSound to prevent shutter sound from playing on iOS
  • Uses it on the example project

Tested on

  • iPhone 13 Pro, iOS 15.5

Related issues

  • Fixes #311

wassgha avatar May 31 '22 17:05 wassgha

@mrousavy can't request you for review, so tagging you here

wassgha avatar May 31 '22 17:05 wassgha

Hi, thanks for your PR!

One minor thing I'd like to have changed is the inheritance/subclass of PhotoCaptureDelegate. Could we maybe instead pass enableShutterSound: ___ to the constructor as usual, and handle it in the original class instead of subclassing it?

Thanks!

mrousavy avatar Jun 01 '22 08:06 mrousavy

I'm thinking if it would be better to call it enableShutterSound instead and have it be true by default? I'm not a big fan of this whole reverse/disable true logic.

mrousavy avatar Jun 01 '22 08:06 mrousavy

Hey.

Looking forward to this being implemented. Is there any eta?

lissau avatar Jul 03 '22 17:07 lissau

@wassgha Hey! Since i see no traction on this review, how do you recommend implementing this?

Should I just add your changes verbatim to the project?

copterisimo avatar Sep 01 '22 04:09 copterisimo

Hey @copterisimo , sorry I couldn't find time to finish this PR. It's good as is if you want to fork it, @mrousavy 's comments are mostly about code organization.

wassgha avatar Sep 01 '22 04:09 wassgha

Hey thanks for your PR and sorry for the long radio silence here! I added shutter sound in V3.1.0

mrousavy avatar Sep 30 '23 13:09 mrousavy