react-native-mmkv icon indicating copy to clipboard operation
react-native-mmkv copied to clipboard
verified publisher icon mrousavy

fix: Update cpp code to support React Native 0.75.1

Open davebray131 opened this issue 1 year ago • 4 comments

Updates cpp code to rename some variables to meet new CodeGen specifications

davebray131 avatar Aug 19 '24 14:08 davebray131

quite a breaking change 😅

mrousavy avatar Aug 19 '24 18:08 mrousavy

please run clang format.

mrousavy avatar Aug 19 '24 18:08 mrousavy

Both iOS and Android builds failed now, so this PR is definitely not backwards compatible. I don't want to introduce a lot of new code with #ifdef and stuff, so maybe I'll just wait a bit before I merge & release this.

People will complain either way

mrousavy avatar Aug 20 '24 21:08 mrousavy

I think that it is perfectly fine to do that. I am content using the patch I created that was posted in the original issue, and I think that will work well for anyone that needs support for 75.1+. Once that version gains more traction these changes can be integrated into the main branch. Thanks for taking the time to look at it.

davebray131 avatar Aug 20 '24 22:08 davebray131

Awesome work, was experiencing the same thing

alon7 avatar Aug 29 '24 15:08 alon7