react-native-mmkv icon indicating copy to clipboard operation
react-native-mmkv copied to clipboard

chore: add ios privacy manifest

Open RhyG opened this issue 3 months ago • 7 comments

Added a privacy manifest file to comply with Apple's upcoming privacy manifest requirements.

I based the reason and type off of Apple's docs for describing use of required reason API and my understanding of what the library uses, but if it's not quite correct let me know and happy to adjust it.

RhyG avatar Mar 23 '24 01:03 RhyG

the underlying library maintainer is removing uses of the apis that trigger the warning (he doesn't seem willing to include a privacy manifest in his library)

last change was made 2 days ago, i'm not sure if he cleaned up all instances of "offending" APIs, so it's probably a good idea to still declare the manifest here 🤷‍♂️ ?

any thoughts @RhyG ?

thanks for your work btw 👍

jbrodriguez avatar Mar 27 '24 13:03 jbrodriguez

Hey - thanks for this PR, this is dope!

But I agree with @jbrodriguez - the maintainer of Tencent/MMKV is removing all the APIs that require such privacy manifests, and I think that's a better solution moving forward. See commits like https://github.com/Tencent/MMKV/commit/1feba14d3347050c181ab3e507ac8121d69ae656

mrousavy avatar Mar 27 '24 13:03 mrousavy

@jbrodriguez @mrousavy fully agree, would rather the permissions gone for sure. That's similar to what react-native-gesture-handler did https://github.com/software-mansion/react-native-gesture-handler/pull/2830

If that lib ends up removing all permissions that means this isn't needed so happy to close this one in favour of that approach 🙂

RhyG avatar Mar 27 '24 20:03 RhyG

Any update on the release of this?

mobileteo avatar Apr 08 '24 09:04 mobileteo

@mrousavy Could you check this PR? It's relatively simple. The alternative is that the manifest has to be set on the app level, which is a little dirty IMO.

cvisserMaxedy avatar Apr 30 '24 08:04 cvisserMaxedy

@mrousavy Could you check this PR? It's relatively simple. The alternative is that the manifest has to be set on the app level, which is a little dirty IMO.

Again, the real solution to this would be to upgrade the core MMKV library and remove all of the sensitive APIs. You can already do that by just running pod update yourself.

In V3 I've already fixed this.

mrousavy avatar Apr 30 '24 08:04 mrousavy

@mrousavy Could you check this PR? It's relatively simple. The alternative is that the manifest has to be set on the app level, which is a little dirty IMO.

Again, the real solution to this would be to upgrade the core MMKV library and remove all of the sensitive APIs. You can already do that by just running pod update yourself.

In V3 I've already fixed this.

My bad, thanks for the reply. I had linked this ticket to track the issue but not realized there was a solution.

cvisserMaxedy avatar Apr 30 '24 08:04 cvisserMaxedy

In that case are you happy for me to close this @mrousavy?

RhyG avatar May 02 '24 03:05 RhyG

yup thx

mrousavy avatar May 02 '24 08:05 mrousavy