nitro icon indicating copy to clipboard operation
nitro copied to clipboard
verified publisher icon mrousavy

[Feature] Support children in Nitro Views

Open plneple opened this issue 3 months ago • 6 comments

Adding a child to a view managed by generated ViewManager causes a runtime crash

plneple avatar Sep 15 '25 07:09 plneple

"a runtime crash"

Without logs I will have to close this issue.

mrousavy avatar Sep 15 '25 10:09 mrousavy

@mrousavy My mistake — I’ll provide the logs. I was expecting this to be a known issue and was mainly curious about the reasoning behind it. I’ll get back to you by EOD.

plneple avatar Sep 15 '25 11:09 plneple

@plneple if the crash is happening on android its because nitro views by default use simpleViewManager which doesn't allow child views. there is a PR #652 that will address this. Will address the merge conflicts @mrousavy would appreciate if you can review it for any changes.

patrickkabwe avatar Sep 15 '25 11:09 patrickkabwe

Yes, that’s exactly what I was referring to.

Thanks, @patrickkabwe!

plneple avatar Sep 15 '25 11:09 plneple

@patrickkabwe I think it'd be better to re-create the PR from scratch - there are a lot of unrelated changes in this PR.

mrousavy avatar Sep 15 '25 11:09 mrousavy

@plneple @mrousavy Any updates on this? I would love to see children support in NitroViews.

Nikhil-GitHub-1 avatar Oct 18 '25 00:10 Nikhil-GitHub-1