HybridObject shows as JSObject(__type) in Hermes memory dumps

[mfazekas]

Feature Request/Enhancement

When creating Nitro's HybridObjects and taking Hermes memory dumps, with react native dev tools Take snapshot , objects are showing up as JSObject(__type) instead of their actual type names (e.g., HybridObject<MyType>), making memory profiling difficult (hard to search for those objects).

Hermes seems to use JSObject::getHeuristicTypeName() to name objects.

The following diff adds a dummy constructor with proper name, to the #ifdef NITRO_DEBUG part of HybridObject::toObject but not sure what side effects that could have. But it makes the dump much nicer

+++ b/packages/react-native-nitro-modules/cpp/core/HybridObject.cpp
@@ -94,6 +94,28 @@ jsi::Value HybridObject::toObject(jsi::Runtime& runtime) {
                                   .value = jsi::String::createFromUtf8(runtime, typeName),
                                   .writable = false,
                               });
+  
+  jsi::Function constructor =
+      jsi::Function::createFromHostFunction(
+        runtime,
+        jsi::PropNameID::forAscii(runtime, typeName),
+        0, // paramCount
+        [](jsi::Runtime& rt, const jsi::Value&, const jsi::Value* args, size_t count) -> jsi::Value {
+          throw jsi::JSError(rt, "This constructor cannot be called");
+          return jsi::Value::undefined();
+        }
+      );
+  ObjectUtils::defineProperty(
+    runtime,
+    object,
+    "constructor",
+    PlainPropertyDescriptor{
+      .configurable = true,
+      .enumerable = false,
+      .value = std::move(constructor),
+      .writable = false,
+    }
+  );
 #endif

Are there any existing workarounds?

No response

Additional information

• [x] I checked the documentation and couldn't find this feature.
• [x] I can create a PR to implement this feature. (See Contributing for more information)
• [x] I searched for similar issues in this repository and found none.

[mrousavy]

interesting. I think we'd probably want constructors here anyways, would be a good addition (in favor of the current way of autolinking)