Marc Rousavy
Marc Rousavy
It always felt off to me, so I wanted to change it. lmk ur thoughts on this PR. Before After https://github.com/user-attachments/assets/991013cd-68ad-4bd6-8d24-25f42fb11f56 https://github.com/user-attachments/assets/8d13a4ca-917c-4e2d-af11-df414f21801f https://github.com/user-attachments/assets/0a19d2bb-33ba-4bf1-b7b9-ee4c8770418e https://github.com/user-attachments/assets/5671fb47-1576-40d1-9db0-56790380c062 sorry I'm a bit perfectionistic when...
## Problem In [Nitro](https://nitro.margelo.com), array buffers are supported types for native modules. Imagine the following native nitro module: ```ts const seedArrayBuffer = myNitroModule.createRandomSeed() const keyString = myNitroModule.getEncryptionKey(seedArrayBuffer) ``` On the...
## Problem Currently, all `jsi::String` factory methods (e.g. `createFromAscii(...)`) **copy** the given `std::string`/`char*`. This could cause unnecessary performance hits if the strings are large, or constexpr/statically known at compile-time ##...
## Summary Fixes the build CI which previously failed silently. See [the last actions run](https://github.com/facebook/hermes/actions/runs/13322712332/job/37210108771), in the end of the logs it fails silently: ``` -- Up-to-date: /Users/runner/work/hermes/hermes/build_appletvsimulator/../destroot/include/jsi/decorator.h -- Up-to-date:...
### What's happening? On Android, errors / exceptions don't have a proper message, and always resort to `Unknown T error` (e.g. `Unknown std::runtime_error error`) instead of using it's message (`what()`)....
- Maybe fixes https://github.com/mrousavy/nitro/issues/628#issuecomment-2783480689
Before, a Java/Kotlin HybridObject always went through C++/std types, even if we discarded them right away since we pass them to Java. For example, for Arrays this looked like this:...
When creating a tuple, the Swift code gets generated but it won't compile. Tuple: ```ts interface MyHybrid extends HybridObject { someFunc(value: [number, number, number]) } ``` Generated Swift: ```swift class...