Marc Rousavy

Results 1289 comments of Marc Rousavy

Also, I'm not merging my library into his, I like my code, it's very clean and minimal. I also like my API more. And my library was using JSI first...

Thank you Raymond, and no offense taken!

Hi! Storing the encryption key in keychain seems to be a good idea, you can either manually do that or shoot me a PR so I can add it to...

I didn't implement it because: > The repair rate is not promised, though. And you might get unexpected key values from recovery And to me that's not a fair tradeoff....

I think if the encryption key is not the same it simply cannot read the data and will overwrite it if you try writing to it. So your data will...

Oh so the new key doesn't even get used? Then I need to change the API? 🤔

Hey! There must be more to that stacktrace - can you symbolicate it?

Oh that's interesting! Could you profile if this happens on Android too?

Hey Bartosz! 1. I'll take a look! Maybe this issue should be reported in the original MMKV repo instead? 2. Yeah well ID cannot be default anymore since the default...

cc @axeldelafosse @nandorojo - do we need the `canUseDOM` check? https://github.com/mrousavy/react-native-mmkv/blob/ab6584a814f9fb48430792ea358873310d3eda8a/src/createMMKV.web.ts#L4-L5