Marc Rousavy

Results 1816 comments of Marc Rousavy

I think this has been fixed in react-native-worklets-core 1.x.x.! 🎉

1. This is weird, on all my test devices (Samsung, Huawei, Google Pixel) the preview looks good. I can take another look but if the issue cannot be reproduced on...

@bruno-centanaro can you submit a PR? I can take a look and others can test this.

> One thing I do not understand is why the `CameraDeviceDetails.getMaximumPreviewSize()` is used for the aspect ratio in `getSize`. This is just the default value. It will be updated later...

> As for the surfaceChanged, you are correct it modifies the size variable but this is not causing the onMeasure to run again, at least on my phone. Interesting -...

I _believe_ that the aspect ratio calculation is correct, are you sure that swapping the aspect ratios is right? Can you just quickly post your diff or what exactly you...

Uhm well this code: ```kt val scaledWidth = containerSize.height * contentAspectRatio val scaledWidth = containerSize.height * containerAspectRatio Size(scaledWidth.roundToInt(), containerSize.height) ``` Effectively does nothing, it's the same as ```kt containerSize ```...

Good feature request, but I think the answer would be the API I mentioned in this comment: https://github.com/mrousavy/react-native-vision-camera/issues/1319#issuecomment-1741728183 So something like ```ts const recorder = await camera.current.prepareRecorder() console.log(recorder.state) //