Marc Rousavy

Results 1816 comments of Marc Rousavy

I can also reproduce this when using `resizeMode="cover"`...

Try playing around with the code from `useSkiaFrameProcessor`: https://github.com/mrousavy/react-native-vision-camera/blob/3ff02cc6b4fc34154ec6fb5e650e074e34408e47/package/src/skia/useSkiaFrameProcessor.ts#L165-L175 Maybe we're doing something wrong. Also, the `ImageProxy` (which is what the native `Frame` type holds) contains a [`getSensorToBufferTransformMatrix()`](https://developer.android.com/reference/androidx/camera/core/ImageInfo#getSensorToBufferTransformMatrix()) method -...

then it's probably the sensor to buffer transform matrix.

I am applying the orientation inside the `render(..)` function, so actually it is expected that the Preview looks correct.

> i mean, `frame.orientation` will always returns `landscape-right` since[ orientation support not being complete on android](https://github.com/mrousavy/react-native-vision-camera/issues/1891), no, `frame.orientation` is an exception here - this is the sensor relative orientation of...

Hey @fahadhaque007 - thanks for your PR, much appreciated!! I have a few concerns regarding this though, mainly about making sure the codebase is clean and doesn't involve a lot...

Also, what is `backgroundLevel`? > Specifies the background torch level of the current camera. This value ranges from 0.0 to 1.0. i still don't get this?

Hey - thanks for the details! The code is definitely good for your use-case, but I don't think this should make it into VisionCamera. The only thing I'm happy to...

Hey - do you want to create a PR for only the `torchLevel` prop? Otherwise I can also do that, that part was still good.