Marc Rousavy

Results 1105 comments of Marc Rousavy

Well obviously you still need the native function, otherwise the patch won't work. That's the whole idea, moving it to native. 😅 The code is closed source for a client...

Can you try cleaning Gradle cache and rebuilding the project?

Can you run the example/ app here? This bug is really weird, maybe try upgrading to RN 0.66?

Hi, thanks for your PR! `appGroup` is a new field that needs to be added to the types and documented so it can be used. Other than that it looks...

That looks like a good solution. We need to create a doc that explains this instead of just linking to this PR though. I'll get to that after I'm back...

Hmm, that sucks - is this the typical way paths are handled on windows?

How often are you writing to MMKV? It's not a database, it's a memory map key value storage.

Hey, this seems to be very weird to let the user set up all of this - I think there's better examples (e.g. Reanimated) that automatically mock everything

Sure, if you shoot me a PR I'll be happy to review, test and merge it :)