Marc Rousavy

Results 1820 comments of Marc Rousavy

The fix for this would be to move `autoDistortionCorrection` from `takePhoto(...)` props to the actual `` view props, then set `self.contentAwareDistortionCorrectionEnabled` to true in the `CameraView+AVCaptureSession.swift` file and in `CameraView+TakePhoto.swift`...

Hi, thanks for your PR! Is the prop required or not? In your code you provide a default value of `0`, what happens if the user doesn't pass one? Is...

I'd just add `if (exposure != null)` to the if so the exposure will not be set if it's null, no?

Hmm actually what happens if the user passes an exposure value and then passes `null` again? Will it be updated to default or will it remain to the last one...

> how all of this is even possible :| Because no code is perfect and I am providing this software without warranty. I built all of it in my **free...

Hey! This seems very similar as #526. In theory; it is possible to build such an interface, but that requires a lot of my free time, which I currently don't...

Actually a hacky solution right now would be to use Frame Processors to detect the faces, and then draw the face-filters ontop of the Camera using [react-native-skia](http://github.com/Shopify/react-native-skia). This should be...

cc @wcandillon & @chrfalch

1. Frame Processors detect the face, and return the bounding box. 2. RN Skia draws a face filter at the bounding box coordinates, smoothly and at 60 FPS, and running...

Hey yes I think this is possible using RN Skia - there's a prop (called draw mode or something) which you can set to SRC_OUT or DST_OUT and it will...