Marc Rousavy
Marc Rousavy
Before you go this extra mile; are we sure we need fully native support for `Set`? This has some overhead due to the JSI calls and JSI constructions (which are...
ok I get it. and you absolutely need `Set`? Normal array doesn't work?
Maybe I can find a way to implement JS-based prototypes as C++ classes, basically the other way around of a HybridObject. I can then implement smarter caching for this. Let...
Why not just .contains() instead of .has()
appreciate the effort for this PR, but I think this type is not super necessary in core - a normal array will work fine for now, you can de-dupe in...
That is super weird. The issue you mentioned (#382) was closed because we fixed the actual problem in upstream react-native core. The issue was, that `-fexceptions` was not enabled in...
Which platforms did you test btw? I see iOS/Swift, but did you also test Android?
> I am not knowledgeable yet on the best practices to throw errors in JSI Just `throw` - that's what I do in Nitro too. I just [wrap them for...
> My assumption is that -fexceptions is enabled by default on newer React Native versions I think so too, that's why I found this issue to be so confusing. I'm...
closed via https://github.com/Shopify/react-native-skia/pull/3595 - thanks @wcandillon