Marc Rousavy

Results 1813 comments of Marc Rousavy

closing since I don't think we should ship this. thanks tho

Hi Ronald! > Sadly the error message doesn't really help much, just shows > ``` > Command SwiftCompile failed with a nonzero exit code > ``` Please read [the Troubleshooting...

This is a Swift bug. Usually I do workarounds for those kinds of things but this is a bit more tricky. Just to be sure; it does work if you...

fixed in https://github.com/margelo/react-native-worklets-core/commit/6918abd77bb1926087186d3bc06f01b7faadb902. Requires RN 0.74 or higher

fixed in https://github.com/margelo/react-native-worklets-core/commit/6918abd77bb1926087186d3bc06f01b7faadb902

Thanks, good repro. I managed to find the bug and fix it, PR is up: https://github.com/mrousavy/nitro/pull/683

I don't think this is a good idea because JSON.parse is never checking for type-safety. It's always theoretically `unknown`.

No this is essentially just a convenience hook, but I agree since I introduced this hook it maybe makes sense to also add it to JS types of MMKV.

> - Incorporate the changes from https://github.com/mrousavy/react-native-mmkv/pull/826, so that storable objects support the correct types. > Thoughts? That shouldn't be part of `MMKV` imo. The rest sounds good - but...

hey - hm this actually seems like a CameraX inconsistency. Thanks for creating the bug report in the CameraX issue tarcker @dorakadri ! :)