Marc Rousavy
Marc Rousavy
So I thought a bit about this and I think this would be too complex to really support. There are tons of cases where you can use wrong names, like...
Thanks for your reply! > Swift will not support throwing C++/ObjC exceptions correctly, so they will not be propagated to C++. C++/ObjC exceptions that are thrown in C++ and not...
No, no update. I haven't looked at this yet.
Yea might be. I was hoping to find a solution to stay within one Pod, as they are so tightly coupled (and versioned) and don't work without each other. A...
Hey thanks for the detailed bug report! Can you try to patch this fix into Nitro Core to see if that fixes your bug? https://github.com/mrousavy/nitro/commit/0589b256332c7d08370546f1652a0cd1cc467673
@dantrongamz your fix in `~JPromise` looks like it should solve the issue - are you sure it still crashes with the same?
Hmm it's crashing here 
Okay 40 minutes later I found the bug.  The problem is that the `~Promise()` destructor: https://github.com/mrousavy/nitro/blob/2ae634c81f570a098ae0a393d970e448a339d0d2/packages/react-native-nitro-modules/cpp/core/Promise.hpp#L36-L41 Is obviously destroying it's fields: https://github.com/mrousavy/nitro/blob/2ae634c81f570a098ae0a393d970e448a339d0d2/packages/react-native-nitro-modules/cpp/core/Promise.hpp#L248-L252 And one of those fields contains a...
PR is up: https://github.com/mrousavy/nitro/pull/683
> Thanks a bunch for this tricky fix! Sure thing! Was a fun one. > Our team has been waiting for it for ages. Next time just contact us through...