Marc Rousavy comments

Results 1813 comments of


                                            Marc Rousavy

🐛 Crash in iOS release build when using SkiaFrameProcessor

Don't really have a lot of free time at the moment.

fix: orientation on iOS

Hi - thank you for your PR! Much appreciated. I will review this asap in the coming days. Thanks!

> onPreviewOrientationChanged and onOutputOrientationChanged do not correctly return the orientation. For example, when the phone is in portrait mode, the returned mode is "landscape-left". That is intended though, no? It...

fix: orientation on iOS

> I think it's preferable to have the same value for the same orientation regardless of the iOS version. Absolutely! Agreed. > Given that the phone is in portrait mode,...

fix: orientation on iOS

Btw what's your handle on Discord? Are you on our community discord? Some thing can be discussed quicker over chat, and I also want to give you the contributor role...

fix: orientation on iOS

Hey - I took another stab at this to implement this in a clean and effective way. Can you check out https://github.com/mrousavy/react-native-vision-camera/pull/3039 to see if that works for you and...

🐛 Focus not working on some Android devices when setting FPS

So this is definitely a CameraX bug then. Can you report it in the CameraX issue tracker?

🐛 Focus not working on some Android devices when setting FPS

(thanks for the detailed testing & logs btw)

🐛 Focus not working on some Android devices when setting FPS

Did you post a CameraX issue? If yes, please link it here for visibility.

🐛 outputOrientation not working in android but working properly in iOS.

Set `outputOrientation="preview"`, that should work.