scmpuff icon indicating copy to clipboard operation
scmpuff copied to clipboard

Powershell on Windows support

Open kmatt opened this issue 1 year ago • 3 comments

Building on work in #14:

  • Update Git wrapper script
  • Powershell status commands script
  • Documentation update

kmatt avatar Jul 11 '24 23:07 kmatt

Sorry for the delay in response I was OOO at a conference. This looks great! 🎉 Really appreciate the work here. ❤️ Do you have thoughts on how we can integrate the Powershell testing into the CI? (I also don't have a Windows machine to verify manually.)

mroth avatar Jul 16 '24 14:07 mroth

@mroth Not sure on CI based tests yet. So far I have only run go test as in the Rakefile. On Windows 11:

> go test ./...
?       github.com/mroth/scmpuff        [no test files]
?       github.com/mroth/scmpuff/commands/exec  [no test files]
?       github.com/mroth/scmpuff/commands/intro [no test files]
ok      github.com/mroth/scmpuff/commands/expand        0.078s
ok      github.com/mroth/scmpuff/commands/inits 0.078s
ok      github.com/mroth/scmpuff/commands/internal/arguments    0.066s
ok      github.com/mroth/scmpuff/commands/status        0.071s

kmatt avatar Jul 16 '24 16:07 kmatt

I approved the PR running in CI, so you should be able to see the output there as well for integration tests now.

The integration tests are (unfortunately? fortunately?) currently all still implemented in Aruba with Ruby. You can see https://github.com/mroth/scmpuff/commit/867661ad910138c3f801f62428ce4b3f2e271ad5 as an example of what it looked like to add another shell to the test grid (this was also the PR that added multi-shell support to integration tests).

A few changes there should be enough to get it to work locally -- I suspect there might then have to be some other changes in the GitHub Actions scripts to only run PS tests on Windows runners, etc, but that part should hopefully be straightforward.

mroth avatar Jul 20 '24 11:07 mroth