scmpuff icon indicating copy to clipboard operation
scmpuff copied to clipboard

Quote $@ and make $file and $files local in `scmpuff init -s`

Open HaleTom opened this issue 4 years ago • 2 comments

As per title.

for local file in...

Also $@ is not quoted.

Would you consider running shellcheck over the codebase? (It would have picked up the $@ quoting.)

HaleTom avatar Oct 22 '20 11:10 HaleTom

This makes a lot of sense, it should be possible to integrate shellcheck into the CI fairly easily with GitHub Actions.

mroth avatar Oct 26 '20 15:10 mroth

@HaleTom I started addressing this in #57, if you wouldn't mind taking a look, I have some questions and would appreciate your input.

mroth avatar Dec 06 '21 01:12 mroth