jflect icon indicating copy to clipboard operation
jflect copied to clipboard

Update main.go

Open mathew-bowersox opened this issue 6 years ago • 2 comments

Exporting your read function so it can be used when using your code as a library

mathew-bowersox avatar Jul 15 '19 14:07 mathew-bowersox

Thanks for this patch @mathew-bowersox . I'm assuming you are importing this in which case this patch will work fine for you. However as it stands this would break main() and the tests in main_test.go. If you could update this patch so that go test works. and main() still works. I'll merge the patch.

Additionally to do this correctly main should be moved to cmd/jfect and package code should move to pkg along with tests. Then anything can import github.com/mrosset/jflect/pkg including cmd/jflect.

mrosset avatar Jul 15 '19 15:07 mrosset

@mathew-bowersox thanks for the changes, just a couple of things to fix and then almost done.

mrosset avatar Jul 16 '19 20:07 mrosset