Add `sideEffects: false` to package.json

[neoncube2]

Hello! :)

Can sideEffects: false please be added to package.json? This can enable more tree-shaking, in some cases: https://github.com/webpack/webpack/blob/main/examples/side-effects/README.md

Other popular libraries, such as axios, have already added this flag: https://github.com/axios/axios/pull/5025

I'd be happy to open a PR :)

(Also true for deeks and doc-path)

[mrodrig]

Hi @neoncube2, Thanks for the suggestion and for reporting this! That's a great idea, and I'd be happy to accept a pull request that adds sideEffects: false to the package.json file. I appreciate you pointing this out and providing the extra context.

I look forward to reviewing your PR!

[neoncube2]

Hi, @mrodrig,

I gave this a shot, but it turns out that in order for this flag to be useful, the library need to be an ESModule (I guess?). (More documentation about the sideEffects flag)

Have you thought about upgrading this module to an ESModule? I think this would make it so that the package would only run on the latest versions of node.js but would lead to smaller bundle sizes when used on the web. No worries if you don't want to upgrade to ESM, since I suspect that this library is mostly used on node.js, but I figured I'd ask :)

[neoncube2]

I went ahead and opened a PR for this. I think this might be helpful even if the library doesn't use ESModules, for the reasons I detailed here: https://github.com/eugenezinovyev/react-fontawesome-svg-icon/issues/36#issuecomment-3663844017 :)