Martin Robinson
Martin Robinson
This could make sense, but I think it should be guided by measurement. Layout, is one of the more lightweight parts of Servo. You can observe this by compiling Servo...
Here's my attempt as fixing these issues: https://github.com/servo/servo/commit/41bde5279866347c4e7da2688cf9c28b24bb893b I'm stuck fighting with the borrow checker. It's unclear how to create a JValue from a Rust string and pass it to...
@mukilan Would you mind pushing your changes to @delan's branch so we can land them?
Nice!
This will likely have to wait until `@font-face` are stored in the per-layout data structures: https://github.com/servo/servo/issues/32033.
The `FontContext` will hold all per-layout `FontTemplate`s which will allow specifying `unicode-range`, `font-style`, etc. These special templates will be per-layout even if they ultimately point to system fonts.
This should have been fixed by #32303.
It looks like the test is failing: ``` failures: ---- fetch::test_local_directory_listing stdout ---- thread 'fetch::test_local_directory_listing' panicked at components/net/tests/fetch.rs:402:13: assertion `left == right` failed left: "\n\nDirectory listing: /home/runner/work/servo/servo/tests/wpt/directory-listing-example\n \n h1 {\n...
FWIW Servo has no accessibility support at the moment so this conversation is highly hypothetical. That said, I'm not sure that a table is really helpful for AT users here....
I think this is a great idea. I agree that running clippy when running tidy would be too slow, but how about just adding a new GitHub CI "lint" job...