Martin Robinson

Results 197 comments of Martin Robinson

@Arnav2824 Apologies, I mistyped the name of the repository. It is: https://github.com/servo/string-cache

> @Arnav2824 Apologies, I mistyped the name of the repository. It is: https://github.com/servo/string-cache It looks like there is already a PR up for this issue at https://github.com/servo/string-cache/pull/281.

Looks like there are a lot of timeouts in MediaQuery tests and also another test using `load` (/css/css-values/viewport-units-after-font-load.html) events. Could it be that there's an issue with `load` events?

> BTW, some of the clippy warnings can be fixed automatically, e.g. > > ``` > CARGO_BUILD_RUSTC=rustc cargo clippy --fix -p layout_2020 --broken-code > ``` > > will apply some...

@rohansx Do you plan to keep working on this one?

It seems this is an issue when sending the output to the intermittent dashboard. I think a simple solution here would be to truncate the output.

I think the first step is getting to bottom of what part of the filtering process is hitting the limits and then going from there. It's quite likely that we...

@gterzian This is a great point. The other consideration for the multiprocess case is sandboxing. I think the solution here is to have the `FontCacheThread` in the UI-process responsible for...

> Perhaps `Arc`, `Arc` or `Arc`? I don't think `Arc` ever makes sense. Yep, I meant `Arc` here. I've corrected the text above.

> With "the UI-process" do you mean the content-process(where script and layout runs)? If so that would mean running multiple font threads, one per content-process, which I think would defeat...