Martin Robinson

Results 446 comments of Martin Robinson

@waywardmonkeys This should probably be considered before a major release. Do you mind reviewing?

Servo is setting the MACOSX_DEPLOYMENT_TARGET to `10.10` in `.cargo/config.toml`. I believe this was previously set in the environment by `mach`.

> In Firefox and Chrome, the deltaY is positive when scrolling down. Meanwhile in servo it's negative. If the issue is the value that is passed to DOM events then...

> I like the cleanup. The timing call is unfortunate, so let's try to see if that's unnecessary? Maybe we can return `Self` as well and call it? Or do...

I've had to post a modification to this change which does two things: - Integrates `EventSource` into the typical workflow for starting fetch operations and properly creates a new `FetchListener`...

This seems to have fixed an issue with resource timing tests due to the fact that the resource timing is now set before events are fired. This is possible because...

Hrm. It seems that these changes had too many side effects on the resource timing code so I have made another attempt to preserve the old behavior (which was also...

To expand, creating an `Arc` that isn't `Send` and `Sync` means that the `Arc` itself isn't `Send` and `Sync` either. Normally trying to pass an instance of such a struct...

> So I tried out the Rc change and it is throwing me some 4 errors. I think Arc is needed here? I think the code is being used in...