Martin Robinson

Results 197 comments of Martin Robinson

@Nopey Honestly, that stack looks unrelated to your changes to Python. The WPT Export errors seem unrelated as well, perhaps you need to rebase and squash some of your changes...

> .\mach test-tidy fails with that stacktrace locally if (and only if) the python script does not match the one on servo/main. > > Adding two newlines to the end...

In order to fix the WPT Export job you need to rebase your branch and remove all of the merge commits.

A new version of harfbuzz has been released, which should help unblock this.

@Taym95 Do you mind taking a look at the failing tests? It seems that this change introduces some failure and timeouts.

@Taym95 Any updates on this one? Is there some way that I can help you get this ready for review again?

> Remove direct use of filesystem to make it compilable into wasm. I could see [this use of WalkDir](https://github.com/servo/servo/blob/2fbb120e94013d0387eaa8c3fc6d649aed7f599f/components/style/build.rs#L46), not sure if that is what was meant. Servo configs seems...

I think we can go ahead and close this one, but we should can open up other issues to track specific things that we can clean up about the style...

This is quite likely the result of https://github.com/servo/servo/commit/7fa4ea9740edccc93672d8cc428f6e9d4575a036.

There is a section of Linux runtime dependencies listed at https://github.com/servo/servo/#runtime-dependencies. Ideally, if there is a new runtime dependency it should be added there. Unfortunately, it looks like the current...