Martin Roa Villescas
Martin Roa Villescas
Sure. I'll give it a shot.
> Good catch. > Hopefully it should be easy enough to fix. Would you like to make a PR? Have you had a chance to look at the PR? Regards.
> A PR to`TreeView.jl` saying how to do this would be welcome! Have you had a chance to look at the PR? Regards.
I also have networkx 3.2.1. Here is the rest of my installed dependencies: pip list | Package | Version | |--------------------------|-----------| | asttokens | 2.4.1 | | decorator | 5.1.1...
Would there be any advantage of using a non-standard string literal over a macro? E.g.: ```julia algo = compile"problems/asia/asia.uai" obsvars, obsvals = Int64[], Int64[] marginals = run_algo(algo, obsvars, obsvals) ```
Right. You have a point. But putting aside the extra arguments that we might want to pass to `compile_algo`, would this bring benefits over a standard macro? I think we...
Ahh, macros do support `varargs`. Great. Then I think we should go with this approach. I also want to rename the `run_algo` function to `infer`.
> The minimum fix should be like > > ```julia > using JunctionTrees > > problem_number = "34" > problem_filename = joinpath("Promedus_" * problem_number) > problem_dir = joinpath(@__DIR__, "../examples/problems/Promedus/", problem_number)...
The ASIA dataset is located inside the docs dir: https://github.com/mroavi/JunctionTrees.jl/tree/master/docs/src/problems/asia
Yeah, maybe it would be a good idea to use only one dir for all problem datasets.