RollbarSharp icon indicating copy to clipboard operation
RollbarSharp copied to clipboard
verified publisher icon mroach

Remove dependency on System.Web.Routing

Open Dashue opened this issue 10 years ago • 3 comments

Unfortunately this is a no go for me because of that dependency.

Running on NancyFx

Dashue avatar Nov 15 '15 21:11 Dashue

Could you suggetst a pull-request?

AlbertoMonteiro avatar Nov 17 '15 12:11 AlbertoMonteiro

@AlbertoMonteiro @mroach -- Is there still a dependency on System.Web.Routing? It only seems like it matters for the MVC4Tests?

Specifically, I removed the reference on the RollbarSharp.csproj and everything built fine and tests passed. I'd expect something to go wrong if this was needed?

philipbjorge avatar Feb 24 '16 06:02 philipbjorge

It is indirectly used in RequestModelBuilder, the RequestContext object.

https://github.com/mroach/RollbarSharp/blob/master/src/RollbarSharp/Builders/RequestModelBuilder.cs#L49

richardversluis avatar Mar 18 '16 15:03 richardversluis