MROGeometry icon indicating copy to clipboard operation
MROGeometry copied to clipboard

Fix bug with smooth curves

Open morrowa opened this issue 12 years ago • 3 comments

Certain smooth curves were generating sharp/jagged lines where they intersected with the following line. I went through and reworked portions of the algorithm to fix it. Unfortunately I can't give an example because the content I was working with is copyrighted.

morrowa avatar Jul 11 '13 22:07 morrowa

a quick follow up: I turned the pile of code into a proper Xcode project for a static lib - see 03bcc111125. I'll see how to fix the failing XCTest first, then go for ARC and finally making up a test for the failing cases you mention.

Frankly I don't quite understand the failing cases - can you add a sketch? Just draw on a napkin, make a photo and add it here if you like.

mro avatar Feb 27 '14 22:02 mro

Oh man, it's been such a long time that I can't remember what the exact failing cases were. At the time, I was being paid to develop a children's coloring app that used SVG files as input. Unfortunately, I don't have a copy of (or the rights to) the file that was failing. Basically, it was a clockwise corner in an SVG file exported by Illustrator that was creating a loop instead of a smooth corner.

morrowa avatar Feb 27 '14 22:02 morrowa

apologies for the long mute - and thanks a lot for the hint!

I'll do a bunch of test cases and have an eye on the case you mention.

mro avatar Feb 27 '14 22:02 mro