netty-socketio icon indicating copy to clipboard operation
netty-socketio copied to clipboard

Fix #925 Memory Leak while WebSocketServerHandshakeException or Channel failed

Open HashJang opened this issue 1 year ago • 2 comments

fix #925

HashJang avatar Jul 28 '23 02:07 HashJang

this logic should be implemented in com.corundumstudio.socketio.handler.ClientHead#onChannelDisconnect() method without ScheduledExecutorService usage.

but like the bug this time, onChannelDisconnect is called indeed(due to scheduled ping timeout), but the namespaceClients does not contain the client which throw WebSocketException, which result in the uuid2clients does not remove it.

however, i cannot complain if you stick that this is not required, i can still remove it and keep the memory leak fixed, first thing first @mrniko

HashJang avatar Aug 04 '23 02:08 HashJang

@mrniko @HashJang Any updates on this one? I am also facing the same issue in the production. Fix for this would be highly appreciated!

h3mant-1 avatar Jun 11 '24 15:06 h3mant-1

@mrniko Any update?

dengliming avatar Jul 19 '24 17:07 dengliming

@dengliming

I think it's fixed in https://github.com/h3mant-1/netty-socketio/commit/fb467074a62c2528fdb1ba0f5a0610e90ddf3928

mrniko avatar Jul 24 '24 16:07 mrniko

Thanks, Looking forward to the release.

dengliming avatar Jul 25 '24 07:07 dengliming

Released in 2.0.12 version

mrniko avatar Jul 25 '24 13:07 mrniko