netty-socketio
netty-socketio copied to clipboard
Fix #925 Memory Leak while WebSocketServerHandshakeException or Channel failed
fix #925
this logic should be implemented in com.corundumstudio.socketio.handler.ClientHead#onChannelDisconnect() method without ScheduledExecutorService usage.
but like the bug this time, onChannelDisconnect
is called indeed(due to scheduled ping timeout), but the namespaceClients
does not contain the client which throw WebSocketException, which result in the uuid2clients
does not remove it.
however, i cannot complain if you stick that this is not required, i can still remove it and keep the memory leak fixed, first thing first @mrniko
@mrniko @HashJang Any updates on this one? I am also facing the same issue in the production. Fix for this would be highly appreciated!
@mrniko Any update?
@dengliming
I think it's fixed in https://github.com/h3mant-1/netty-socketio/commit/fb467074a62c2528fdb1ba0f5a0610e90ddf3928
Thanks, Looking forward to the release.
Released in 2.0.12 version