netty-socketio icon indicating copy to clipboard operation
netty-socketio copied to clipboard

[Question] Why not optimize Namespace's method ('addListeners') to support Collection

Open damonxue opened this issue 2 years ago • 1 comments

Why not optimize Namespace's method ('addListeners') to support Collection.

@Override
    public void addListeners(Object listeners) {
        if(listeners instanceof Collection){
                 Collection<Object> list = (Collection)listeners;
                 list.stream.forEach( listener ->
                           addListeners(listener , listener.getClass());
                 );
                 return;
        }
        addListeners(listeners, listeners.getClass());
    }

    @Override
    public void addListeners(Object listeners, Class listenersClass) {
        engine.scan(this, listeners, listenersClass);
    }

damonxue avatar May 09 '22 08:05 damonxue

I believe that pr is welcome.

liangyuanpeng avatar Jun 24 '22 15:06 liangyuanpeng