vscode-scss icon indicating copy to clipboard operation
vscode-scss copied to clipboard

fix(completion): add TextEdit for fix #79

Open yoyo930021 opened this issue 4 years ago • 4 comments

  • [x] Use TextEdit to fix #79, because LSP spec write this:
The `insertText` is subject to interpretation by the client side.
Some tools might not take the string literally. For example
VS Code when code complete is requested in this example `con<cursor position>`
and a completion item with an `insertText` of `console` is provided itwill only insert `sole`. Therefore it is recommended to use `textEdit` instead
since it avoids additional client side interpretation.
  • [x] Add trace server option

yoyo930021 avatar Dec 12 '19 10:12 yoyo930021

This pull request is now in conflicts. Could you fix it?

mergify[bot] avatar Mar 22 '20 15:03 mergify[bot]

Sorry for trigger from the bot.

I'll try to get back to this PR later. Looks like the original issue is https://github.com/mrmlnc/vscode-scss/issues/79#issuecomment-589976014.

mrmlnc avatar Mar 22 '20 15:03 mrmlnc

I have the same problem when Vue file for only two vscode extensions. But this solution is too naive, I will update after having time.

yoyo930021 avatar Mar 22 '20 15:03 yoyo930021

@mrmlnc I updated this PR.

yoyo930021 avatar Apr 30 '20 13:04 yoyo930021