vscode-less icon indicating copy to clipboard operation
vscode-less copied to clipboard

[Discussion] [Live Share] Restricting language services to local files

Open lostintangent opened this issue 6 years ago • 2 comments

In preparation for Visual Studio Live Share adding support for "guests" to receive remote language services for Less, this PR simply updates the current DocumentSelector to be limited to file and untitled (unsaved) files. This way, when someone has the Less extension installed, and joins a Live Share session (where files use the vsls: scheme), their language services will be entirely derived from the remote/host side, which provides a more accurate and project-wide experience (guests in Live Share don't have local file access to the project they're collaborating with).

Note: As an example, the TypeScript/JavaScript language services that come in-box with VS Code already have this scheme restriction, and so this PR replicates that behavior.

lostintangent avatar Apr 16 '18 19:04 lostintangent

@mrmlnc I'm not sure whether the build failure is due to this PR? Is there anything I could do to help unblock it?

lostintangent avatar Apr 26 '18 20:04 lostintangent

Hi, @lostintangent,

Sorry for the long answer (difficult week). In recent months, I have little time to support my projects. In the summer I plan to take up this project again.

I understand correctly that you want to add untitled document support to this plugin, not to Less, which is contained in the editor?

I'm not sure whether the build failure is due to this PR?

Unfortunately, this repository is a bit outdated and needs cosmetic repairs.

mrmlnc avatar Apr 29 '18 05:04 mrmlnc