fast-glob icon indicating copy to clipboard operation
fast-glob copied to clipboard

glob-parent audit issue

Open nicososadmi opened this issue 1 year ago • 10 comments

Environment

  • OS Version: Windows 10
  • Node.js Version: 14.17

Actual behavior

After install fast-glob npm throws audit security issues with that dependency glob-parent that version should be >= 6.0.1

Expected behavior

Install fast-glob without any npm audit security issue

Steps to reproduce

npm install fast-glob

nicososadmi avatar Jul 18 '22 20:07 nicososadmi

fast-glob presently pins glob-parent to v5, which isn't currently patched. This issue impacts Yarn users, which both transitively depend on fast-glob.

Kurt-von-Laven avatar Jul 18 '22 21:07 Kurt-von-Laven

@Kurt-von-Laven can you approve this PR? https://github.com/mrmlnc/fast-glob/pull/367

nicososadmi avatar Jul 18 '22 21:07 nicososadmi

Yes, but it won't do you any good.

Kurt-von-Laven avatar Jul 18 '22 22:07 Kurt-von-Laven

chokidar claims that glob-parent v5.1.2 is not vulnerable: https://github.com/paulmillr/chokidar/issues/1191

Eusebius1920 avatar Jul 19 '22 09:07 Eusebius1920

It is not vulnerable, so the bug is bogus, you need to report this issue to Github support, which errorneusly added the cve to dependabot

paulmillr avatar Jul 19 '22 11:07 paulmillr

https://github.com/github/advisory-database/pull/531

paulmillr avatar Jul 19 '22 11:07 paulmillr

following

fhljys avatar Jul 26 '22 02:07 fhljys

@fhljys FYI, you can click on "Subscribe" in the "Notifications" section in order to follow a thread if that is your intention in posting.

Kurt-von-Laven avatar Jul 26 '22 03:07 Kurt-von-Laven

@paulmillr didn't understand what does it mean the bug is bogus? according to the report -> https://github.com/advisories/GHSA-cj88-88mr-972w glob-parent is vulnerable before 6.0.1, can you please clarify?

melwynjensen avatar Jul 26 '22 06:07 melwynjensen

@paulmillr didn't understand what does it mean the bug is bogus? according to the report -> GHSA-cj88-88mr-972w glob-parent is vulnerable before 6.0.1, can you please clarify?

Apparently that report was incorrect (false positive).

Take a look at it again. It got corrected and specifies that 5.1.2 is not vulnerable.

Eusebius1920 avatar Jul 26 '22 07:07 Eusebius1920

@mrmlnc, I believe this issue can safely be closed at this point since it was simply a false positive from a security audit.

Kurt-von-Laven avatar Aug 11 '22 22:08 Kurt-von-Laven