connectr icon indicating copy to clipboard operation
connectr copied to clipboard

rustfm-scrobble v1.0

Open dmfutcher opened this issue 5 years ago • 1 comments

Hey @mrmekon, I'm the author of rustfm-scrobble and can see you use it here. Just wanted to give you a heads-up I released version 1.0 of the library. A lot of fixes & updates so it's likely worth updating. Went to submit a PR myself & saw that you're using a forked version; would be happy to talk about putting your use-case behind a feature flag or something so you can use the library without maintaining a fork. Give me a shout if you have any questions, happy to help.

dmfutcher avatar Nov 01 '19 15:11 dmfutcher

Thanks for the notice, @bobbo. I'll try to bump my fork sometime soon(ish).

I doubt you would want to incorporate my changes upstream. Though this is something I run into a lot with Rust, so it is an interesting thing to keep in mind. rustfm-scrobble uses reqwest for its HTTP client, while connectr uses curl. reqwest is quite large and takes a long time to build, so my fork hacks up rustfm-scrobble to also use curl. This is something I keep running into, where any non-trivial Rust binary ends up linking in 2 or 3 or even 4 different HTTP clients.... ergh.

And thanks for the crate, it has been working perfectly!

mrmekon avatar Nov 03 '19 22:11 mrmekon