CollapseComments icon indicating copy to clipboard operation
CollapseComments copied to clipboard
verified publisher icon mrlacey

Feature: When comments are collapsed show comment Icon

Open SridharPasham opened this issue 5 years ago • 10 comments

Installed product versions

  • Visual Studio: 2019, 16.7
  • This extension: 1.9

Description

When comments are collapsed show comment Icon like in this extension.

Expected behavior

When comments are collapsed show comment Icon.

SridharPasham avatar Aug 11 '20 09:08 SridharPasham

Is it not possible to use both extensions?

mrlacey avatar Aug 11 '20 20:08 mrlacey

I have observed VS slowness when installed that extension. Also found same comments about that extension. Looks like it is not actively maintained.

SridharPasham avatar Aug 19 '20 09:08 SridharPasham

What's the goal here?

Is it that even when collapsed the comments can be distracting and so you'd like them hidden? Or is it something else?

mrlacey avatar Aug 21 '20 19:08 mrlacey

Is it that even when collapsed the comments can be distracting and so you'd like them hidden?

Yes. With some sort of indicator indicating there are hidden comments.

SridharPasham avatar Nov 17 '20 05:11 SridharPasham

Sounds like a great option to have

yannduran avatar Apr 12 '21 12:04 yannduran

What may look like a very simple feature has lots of nuance and hidden complexity.

  • How to handle comments of single vs multi-line length?
  • What other functionality from that other extension should also be considered?
  • How to avoid the performance issues experienced with the other extension? (It needs to do a lot of work to replace the existing/built-in comment experience and provide a custom comment editing experience.)

I don't expect to get to this any time soon but will consider PRs. Although, if you end up recreating everything in the NoComment extension it might be easier to have that as a separate extension you publish yourself.

mrlacey avatar Apr 12 '21 13:04 mrlacey

May be instead to show an icon, allow to change also the style of collapsed comment. I hate the box around a colapsed comment. And font became the default one.

ramoneeza avatar Nov 12 '23 16:11 ramoneeza

Hi,

The extension OP mentioned is obsolete, and it's not available for VS2022. Not necessarily we should copy their approach by displaying a specific icon. Instead, a reasonable compromise would be to print a dummy short "..." text. A new package option may be introduced, let's say ShortCollapseForm. Anyone who wants this feature can explicitly opt-in by enabling this setting.

I just found an old PR I created for the Mad's Tweakster extension. You can see the related issue and PR here. Sounds good enough?

fiseni avatar Oct 01 '24 14:10 fiseni