TrianglePP icon indicating copy to clipboard operation
TrianglePP copied to clipboard

Can you add an ability to use segments?

Open esacape3d opened this issue 4 years ago • 10 comments

First of all, thank you so much for the great wrapper!

It works well with QT example and I'm trying to understand your codes with my humble C++ knowledge. When I looked into the tpp_impl.cpp, the segment part has not been implemented yet, but it's necessary to use holes or constraint outer lines from my understanding.

Can you add this ability?

Thank you in advance! 👍

PS. I'm not familiar with Github yet, so I don't know posting an issue is okay or not. Please let me know if this would be deleted.

esacape3d avatar Dec 19 '20 18:12 esacape3d

Hi! I never thought this would be needed, but yes, I'll add this. Also because in that way one can create cool logos like the Triangle's logo itself!

mrkkrj avatar Dec 21 '20 14:12 mrkkrj

Thank you! I'm looking for a constrained triangulation library and this would be the best if the segment parts are supported. Yes, one can triangulate logos and letters too 👍

esacape3d avatar Dec 21 '20 15:12 esacape3d

I think I could try to add it between Christmas and New Year, it that's OK for you.

mrkkrj avatar Dec 21 '20 21:12 mrkkrj

That would be appreciated! Thanks!

esacape3d avatar Dec 21 '20 22:12 esacape3d

Hi! I added a first impl. for segment constraints. Is it enough for your use case?

mrkkrj avatar Dec 30 '20 12:12 mrkkrj

Not yet included in the GUI demonstrator, sorry!

mrkkrj avatar Dec 30 '20 12:12 mrkkrj

Thank you so much! I'll check it out and let you know if I have further questions.

esacape3d avatar Dec 30 '20 16:12 esacape3d

Are the changes working? Do you need support for holes etc? I added segment visaulization to the GUI DemoApp.

mrkkrj avatar Jan 08 '21 08:01 mrkkrj

@mrkkrj, sorry for the late reply. I have not tried yet but will check it next week. If you can revise the code to create holes, it would be nice. Thank you!

esacape3d avatar Jan 09 '21 13:01 esacape3d

Hi! I added 1st impl. of hole support and its visualisation in the DemoApp. Is this issue corrected with it?

Regards, Marek

mrkkrj avatar Jan 27 '21 10:01 mrkkrj

segments and holes seem to be working

mrkkrj avatar Feb 01 '23 10:02 mrkkrj