Jason Lui

Results 17 comments of Jason Lui

firstly I'd say this error checking isn't very idiomatic after 1.13 release AFAIK. it's more idiomatic to export the err, such as `ErrNotFound`, then users check it like `errors.Is(err, scany.ErrNotFound)`,...

I'll create a PR if you agree with this!

> Maybe you are right, and after 1.13 `errors.Is(err, scany.ErrNotFound)` makes more sense. But I don't see any problems with the `scany.NotFound(err)` approach either. I suppose the issue is with...

> We could solve it by providing the documentation. Besides that, the new users, after not founding any exported sentinel error in the library, would most likely discover the function...

@georgysavva kindly let me know your opinion. you might feel a bit uncomfortable for removing "WithStack", but I think go idiom treats errors as values, and adding context with `fmt.Errorf`...

> Thanks for the PR. It looks good; I agree with everything except for using "%v". I think it should always be "%w" when propagating errors from the underlying database...

would you like to approve running workflows, or would you want to wait until I finish everything?

sorry for the wait @georgysavva, kindly take a look

Hi @georgysavva is there any update?

> Hi @mrkagelui. Everything looks great; thanks for your work! > > > > The only thing that concerns me: the `go.sum` file should also have changed after you updated...