sockjs-tornado icon indicating copy to clipboard operation
sockjs-tornado copied to clipboard

Support for heartbeat?

Open cilia opened this issue 11 years ago • 6 comments

It was claimed that the upcoming SockJS 0.4 will support heartbeat by default. Is there any plan for SockJS-Tornado to support heartbeat?

Just to confirm, for now, using SockJS 0.3.2, we need to implement our own heartbeat mechanism at the application layer?

cilia avatar Nov 09 '12 15:11 cilia

I will add heartbeat support shortly after 0.4 will be officially released.

For 0.3.2 - yes, you have to implement your own heartbeats.

Out of curiosity, why do you want to have heartbeats? To detect than users disconnected before TCP stack will know about it or for some other reasons?

mrjoes avatar Nov 09 '12 15:11 mrjoes

thanks for the confirmation.

yes, the primary use for me is to detect disconnections before TCP signals any problem, and reconnect immediately if possible. My specific use case prefers to have this sort of early detection.

cilia avatar Nov 09 '12 15:11 cilia

hey was this ever implemented? or do we still have to implement our own heartbeat mechanism? thanks

edbaafi avatar Jul 22 '14 16:07 edbaafi

Nope, sockjs never got bidirectional heartbeat support. Sorry.

mrjoes avatar Jul 22 '14 16:07 mrjoes

thanks

edbaafi avatar Jul 22 '14 17:07 edbaafi

See https://github.com/sockjs/sockjs-protocol/wiki/Heartbeats-and-SockJS and #81: heartbeats are now supported from SockJS 0.4.0 upwards

arnuschky avatar Jun 09 '15 16:06 arnuschky