Matt Riedemann
Matt Riedemann
@consideRatio thanks for digging into this in detail. I did change `c.KubeSpawner.k8s_api_threadpool_workers` to match `c.JupyterHub.concurrent_spawn_limit` in our z2jh `extraConfig` value like this: `c.KubeSpawner.k8s_api_threadpool_workers = c.JupyterHub.concurrent_spawn_limit` I'm assuming that worked since...
> Thanks @mriedem, I'm not a fan that a KeyError crashed your app so what I will do is to to instead send that error to the async error callback...
> fyi added handling in v2.1.2 release so that error is reported on error callback instead. I see (f8a5c9906dd9dae42f09a9f566ae1bd90ef94cfa), thanks!
> I think @mriedem refers to the warning on line 2686 in this code section. Yup 👍
Confirmed that the warning happens if `delete_pvc` is not set to False: >Nov 11 19:26:35 hub-6bc49f5445-8ll7b hub WARNING WARNING 2021-11-12T01:26:35.835Z [JupyterHub spawner:2686] No pvc claim-610d58aa08a527753092ff9d to delete. Assuming already deleted....
It seems this code could check if the name provided is `LogDNA` and alias it to `Mezmo` before doing the vendor search query: https://github.com/PagerDuty/terraform-provider-pagerduty/blob/e251ef8c6f37a3ea91d054c98ffa9973af820d08/pagerduty/data_source_pagerduty_vendor.go#L40 It'd be nice to have that...
We always have to set this manually in the UI after creating a new service. We have internal docs with all of our runbooks for our alerts so we link...
If the package requires >= 3.5: https://github.com/jupyter/jupyter_client/blob/6.1.13/setup.py#L79 Why isn't that part of the test matrix? https://github.com/jupyter/jupyter_client/blob/6.1.13/.github/workflows/main.yml#L41
> > > I know, there was something not clear about Python 3.5. Maybe not available with `ubuntu_latest`?
This is the (pip) package list with a successful build: ``` MarkupSafe-1.1.1 Send2Trash-1.5.0 argon2-cffi-20.1.0 async-generator-1.10 attrs-20.3.0 backcall-0.2.0 bleach-3.3.0 certifi-2020.12.5 cffi-1.14.5 chardet-4.0.0 colorcet-2.0.6 cryptography-3.4.7 cvxpy-1.1.11 cycler-0.10.0 decorator-4.4.2 defusedxml-0.7.1 dill-0.3.3 dlx-1.0.4 docplex-2.20.204...