b4 icon indicating copy to clipboard operation
b4 copied to clipboard

Auto-Thankanator: partially applied series lists unapplied commits

Open tleb opened this issue 10 months ago • 0 comments

When a maintainer auto-thanks following a partially applied series, summary contains the full list of commits, including unapplied commits.

Example where only 1-3 got applied:

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/9] spi: dt-bindings: cdns,qspi-nor: sort compatibles alphabetically
      commit: 002514d91fccde2adbe750c9ec5c6207d56c890b
[2/9] spi: dt-bindings: cdns,qspi-nor: add mobileye,eyeq5-ospi compatible
      commit: 52826aee484b3ebb6ed94c1ae89c0944110ed8b1
[3/9] spi: dt-bindings: cdns,qspi-nor: make cdns,fifo-depth optional
      commit: eb4fdb4bf46f875eac3c093f7ff43a223985f7b8
[4/9] spi: cadence-qspi: allow FIFO depth detection
      (no commit info)
[5/9] spi: cadence-qspi: add no-IRQ mode to indirect reads
      (no commit info)
[6/9] spi: cadence-qspi: add early busywait to cqspi_wait_for_bit()
      (no commit info)
[7/9] spi: cadence-qspi: add mobileye,eyeq5-ospi compatible
      (no commit info)

Example uses a custom template. thanks-am-template takes ${summary} variable which gets built in generate_am_thanks(), in b4/ty.py. What would you think of either:

  1. not listing them or,
  2. having a more confident comment such as "(commit not applied)".

Current message is not explicit enough to my eyes. Are there situations currently where "(no commit info)" is outputted but patch is still applied?

tleb avatar Apr 23 '24 13:04 tleb