xword icon indicating copy to clipboard operation
xword copied to clipboard

Swap across/down plugin corrupts puzzle grid

Open jpd236 opened this issue 9 years ago • 1 comments

The swap across/down plugin seems to be broken, at least on Mac.

One issue is that it calls a "SwapDirection" function which appears to have been renamed to "InvertDirection" in https://github.com/mrichards42/xword/commit/cb8e5c8780f4e931a6073dcb139d085faf4f559f.

However, even with that resolved, the grid ends up in a broken state after the swap. Grid numbers shift around as you click through the grid; the selected square doesn't always get highlighted; filled in answers can disappear.

(Given that this plugin folder begins with a "_", it seems like it might have been shelved and thus bitrotted... but I don't see anything at first glance that actually strips out such plugins from release builds. Will file a separate bug for that).

jpd236 avatar Oct 22 '16 20:10 jpd236

Yeah, it's definitely old and broken. I think this was written when the puz library was a lot simpler. I'm sure it would be possible to make it work again, but the novelty wore off pretty quickly, and I didn't bother.

mrichards42 avatar Oct 22 '16 23:10 mrichards42