crc-rs icon indicating copy to clipboard operation
crc-rs copied to clipboard

Published 20 hours ago • verified publisher icon mrhooray

fix benchmarks

Open fkohlgrueber opened this issue 2 years ago • 4 comments

Hi,

I did a couple of straight-forward changes such that cargo bench works again. I also fixed the deprecation warnings in the benchmarks ~and changed the rust edition to 2021~.

Let me know if you want anything changed.

fkohlgrueber avatar May 19 '22 18:05 fkohlgrueber

@akhilles @mrhooray any feedback on this?

fkohlgrueber avatar Aug 01 '22 13:08 fkohlgrueber

I think this bumps the MSRV right? So, might require a major version release.

akhilles avatar Aug 04 '22 18:08 akhilles

Ah right, didn't think about that. Using edition 2021 would bump MSRV from 1.46 to 1.56. I propose to keep the edition to 2018 for now and just integrate the benchmark fixes. Fixing the benchmarks doesn't require increasing MSRV.

Sounds good?

fkohlgrueber avatar Aug 05 '22 17:08 fkohlgrueber

https://github.com/plotters-rs/plotters/issues/398 is causing tests to fail, maybe pin the version to v0.3.1?

akhilles avatar Aug 06 '22 00:08 akhilles