monodepth icon indicating copy to clipboard operation
monodepth copied to clipboard

ResNet-50

Open 7LFB opened this issue 6 years ago • 3 comments

@mrharicot hi, thanks for your share. there are still some questions i cant understand.

  1. the architecture design about resnet50 in the definition of 'resblock': in the standard resnet-50, the shortcut connection should located at the top layer when entering a resblock, just like below: def resblock(self,x,num_layers,num_blocks): out = x out = self.resconv(out, num_layers, 2) for i in range(num_blocks - 1): out = self.resconv(out, num_layers, 1) return out

    is it right? or are there some other intention for the original design in your code?

7LFB avatar Dec 08 '17 02:12 7LFB

Hi @7LFB, I think you are correct. My implementation of Resnet50 was quite last minute and has actually another bug. I will leave it as is for now to make sure people can reproduce the results from the publication. I however plan on having either a branch or a fork to fix all the bugs at some point in the near future.

mrharicot avatar Dec 08 '17 17:12 mrharicot

HI @mrharicot,

Could you tell about the other bug/s?

alasin avatar Jan 02 '18 06:01 alasin

Hi, are you sure this is a bug? From my point of view, the shortcut connection is just x, so the line you were saying might be just the convolution of number of layers. The actual convolution which complete the job to resblock is inside def resconv. (the last line) return tf.nn.elu(conv3 + shortcut)

keishatsai avatar Jan 31 '18 09:01 keishatsai