MUP icon indicating copy to clipboard operation
MUP copied to clipboard

Compatibility with Mohist Server?

Open Zilacon opened this issue 4 years ago • 2 comments

Hello, would you be able to add compatibility to use this on Mohist? https://github.com/Mohist-Community/Mohist

Also can this mod be used server side only? It throws a mod rejection if the client doesnt have it, anything i can disable to allow clients without it to join?

Zilacon avatar Feb 26 '20 04:02 Zilacon

Unfortunately I don't really have much time to verify compatibility with Mohist. I'd never heard of it until now. Does it need custom builds, or does the mod just fail to load due to a conflict?

Regarding server side only use, the code has been designed with such a use case in mind, but it needs a little more love to make it work properly. Not all bug fixes will be possible, but many are.

If you or anyone else wants to try their hand at it. The "ConfigPacketHandler" class would need to detect vanilla clients, not send config sync packets, and disable any patches that are registered as "PatchDef.Side.BOTH" or "PatchDef.Side.CLIENT". Further, a new "PatchDef.Side" Enum entry could be added called "ANY" for patches that could work either way. A good example is the MC-134989 patch.

I'm not sure when I'll be able to get around to properly implementing server side only use, but I'll keep this open for if/when I get to it or for anyone that wants to attempt it themselves.

mrgrim avatar Feb 29 '20 22:02 mrgrim

One of my developers attempted to make a server only version, which did start and allowed people to join without it on their client. But something in it completely derped.

I use a lot of other performance mods on my server to try and squeeze everything i can out of it. MUP didn't like something and ended up corrupting the entire world.

Newlight WAS disabled, but seemed to be modifying the classes anyways. Other mods used:

  • BetterFPS
  • AI Improvements
  • Performant
  • FoamFix
  • Phosphor
  • BornInABarn
  • ChunkGenLimiter
  • FastLeafDecay
  • MultithreadedNoise
  • Surge
  • VanillaFix
  • RandomPatches

Screenshot_356

Here is the jar: https://cdn.discordapp.com/attachments/373400753085349890/683504719758360576/1.12.2-MUP-1.3.8-PATCHED.jar

Mohist is a hybrid server, so it runs Bukkit and Forge instead of Forge and Sponge. Unlike sponge thats a mod and needs to load like one, a hybrid server using bukkit is hard coded around the API's and running them on seperate threads. So instead of running the forge server, your running a server that uses the forge and bukkit apis to load their mods/plugins.

Zilacon avatar Mar 01 '20 02:03 Zilacon