Momo Kornher
Momo Kornher
This looks awesome! I really like the API surface. I think the current setup is great as a standalone tool, but not ideal for use in other packages. For example...
https://docs.aws.amazon.com/cdk/api/v2/python/aws_cdk.aws_ecs/ServiceManagedEBSVolumeConfiguration.html Is `managed_eBSVolume` Should be `managed_ebs_volume` ```python volume = ecs.ServiceManagedVolume(self, "EBSVolume", name="ebs1", managed_ebs_volume=ecs.ServiceManagedEBSVolumeConfiguration( size= Size.gibibytes(15), volume_type=ec2.EbsDeviceVolumeType.GP3, file_system_type=ecs.FileSystemType.XFS, tag_specifications=[ecs.EBSTagSpecification( tags={ "purpose": "production" }, propagate_tags=ecs.EbsPropagatedTagSource.SERVICE )] ) ) ```
Using the example workflow in the readme, the action will fail when a PR is merged that does not have a backport label. This is functionally correct, but causes confusion...
Fixes #897 PR is in draft. Changing the URL created a bunch of (potential) problems that need to be looked at and solved before it can be merged.
URL: https://github.com/aws/serverless-application-model/blob/develop/schema_source/sam.schema.json
Fixes # --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
### Describe the bug When sending a value from the jsii-kernel back to the caller (
A breaking change in esbuild v0.22.0 change the default bundling behavior for node packages from bundling packages to not bundling them. This came out of nowhere and I'm not entirely...
With the release of esbuild [v0.22.0](https://github.com/evanw/esbuild/releases/tag/v0.22.0), external node packages are by default NOT included in bundles anymore. This likely breaks most usage of esbuild with this package. **Update:** v0.23.0 has...
Resolves #181