Momo Kornher comments

Results 713 comments of


                                            Momo Kornher

dependency upgrade may bump major versions of transitive dependencies

Always happy to expose additional options in the API. Not convinced this would be a sensible default though, I don't really want projen to be too much in the business...

Python class (Interface) is generated out of order

Run into the same issue while working on unrelated stuff. Will look into this. ```ts /** * This module demonstrates covariant overrides support in jsii. * * Covariant overrides allow...

Python class (Interface) is generated out of order

I think I've finally tracked this down. Which is quite something and understandably why it was hard to reproduce. This seems to happen when the code is in a submodule...

Upgrade dependencies workflow overwrites human effort on upgrade branch

Yes ``` depsUpgradeOptions: { workflow: false, }, ```

`projen package` fails on Windows using NPM

Thanks for the report! I thought we had a test running in windows for this 😐

String Enum values compile to the key rather than source value

Not entirely sure about the implications here. We might need to enforce that always enum keys == value

An artifact with this name already exists on the workflow run

> Oh, I think I found prior art: > > ```yaml > - uses: actions/upload-artifact@v4 > with: > name: repo.patch-${{ strategy.job-index }} > ``` > > Not sure if the...

An artifact with this name already exists on the workflow run

> That's not a good option, as the mutations can happen differently in both matrices. Agreed. But committing the mutations from two build doesn't work either. You might not care...

projen new awscdk-app-ts creates a git subproject

Am I right this only happens when you run `projen new` inside an existing git directory? I'm not aware of any recent changes in this area. It stands to reason...

projen new awscdk-app-ts creates a git subproject

I've got no stakes for either way. I'm sure some people will rely on the fact it currently behaves that way. Might be best to do a poll on `cdk.dev`...