Momo Kornher

Results 261 comments of Momo Kornher

This sounds reasonable. I don't develop on windows myself (I use WSL), nor do we currently have a proper test suite for it. But I think it's safe to assume...

The `release` task on any kind of `JsiiProject` is just really bad. The proper fix is to completely get rid of this conditional behavior. I'm very strongly of the opinion...

That looks great! > Would it be in scope for projen to generate these (gitlab-ci.yaml files) as well? > How would one start work on supporting such a feature? Yes,...

> rdewaele_editing_in_vim.jpg 🙃😅 ??? > I can currently offer no guarantees regarding time to work on a projen feature. I do think I can formulate a use case for my...

> > ??? > > You were asking about the code that is generating GitLab snippet. There is no such code. The snippet was manually written by me. Okay, but...

Ah now I'm with you. 😅 All good. We all know that stuff sometimes doesn't translate well I'm text form. I didn't even click that that's your username 🤦

That's unlikely to ever happen given that projenrc files are typically code written in a general purpose programming language. This could work for `.projenrc.json` but I'm not sure how popular...

> PS - This should be the last PR for a bit, in case you were worried. I'm worried that this is the last one 😢 Your PRs are most...

Ahahaha. _cry sob_ I'll need some time to look at this then. Would you mind splitting the PR up anyway please? We can get the new methods out at least.

Closing to tidy up and because this now has conflicts. Changes are still welcome, but we will need separate PRs for the additional methods and the change to the defaults.