Momo Kornher

Results 261 comments of Momo Kornher

> @mrgrain I've added concurrency to the publishing step. Does this alleviate your concern? Yes, it does address the speed improvements. --- In the PR and issue you seem to...

@misterjoshua That looks like the right direction, but let's wait for @rix0rrr 's feedback first.

Hey @Rabadash8820 change looks good but could you please make sure your code is using the correct styling. You can run the linter locally to fix or the PR build...

@Rabadash8820 I've been there. The build posts a comment with link to the public build logs. https://github.com/aws/aws-cdk/pull/21075#issuecomment-1209215774 Will be much easier if you run `yarn lint` in the pipelines project...

Discussed this with @otaviomacedo and @corymhall and it appears there's no quick win to fix this without breaking people. We'll look into a more generic proposal.

Thanks for the explanation @jmortlock . I'm with you now. Good work on the API design, I like. We will give this another review once the building is passing.

@jmortlock Apologies for side tracking this with my request to upgrade the integration test style. I've tracked the build failure down to the fact that these tests are `.lit.ts` files,...

> I think however and perhaps this is a CDKv2 breakage that the rewritten imports are not really what the customer would be using; and the original ones in the...

@WtfJoke Like I said in the gist, I like the direction of this API but we'll need to find a way how to encode VPC and Auth. Maybe they are...