dimensions
dimensions copied to clipboard
mrflix
Zoomed page breaks measuring
With non 100% page zoom: indicators are offset and seemingly broken.
Screenshot of measuring on https://github.com/mrflix/dimensions with 110% zoom:
Hey myfonj, thanks for reporting. Several people already noted that. Yes, Dimensions is broken when in zoom-mode. I don't quite understand why people would want to measure things while zoomed in, but I'll look into it.
@myfonj: just wondering, what would be the use case for measuring things when the zoom has been modified?
tl;dr: modifying page zoom should be legitimate action that should not have any negative consequences.
I agree that this might be just a border case and it may seem weird, but I can give you my own userstory: I have my Chrome set so it's implicit "Page zoom" is 110% to correct it's wonky tiny text display on my 10.1" display with 1368×768 physical resolution even with 125% system zoom. I'm not visually impaired, I just prefer larger texts.
I suspect Chrome does not obey system zoom or has some other issue. And I suspect that the fact things become broken depending on seemingly innocent setting (implicit page zoom), which developers should not worry about (ie this extension should work regardless of the page zoom, because dimensions that this extension measures are essentially virtual pixels, not physical screen dimensions), is mark of some nasty flaw in current Chrome. This is not the first quirk I spotted with this setting. Recently I've encountered this in https://github.com/LeaVerou/prism/issues/336 .
Do you find this argument valid?
@myfonj: I'm not the dev to say if it's a valid argument to include or take care of this use-case. Anyhow, IMHO when developing you don't really need to measure things with the zoom altered. I mean, it's fine to test and play with the zoom to see if everything work as expected, but if you're off by couple of pixels shouldn't be a big deal. Again, my opinion; I could be wrong... and usually I am. :P
Okay so I found time to look deeper into this. Unfortunately Chrome only just now starts to implement the API's to detect zoom changes and get the zoom value (see Chrome Developer Docs). They will be available in Chrome version 38 which is not yet out.
If I implement it now I have to do a lot of if(chrome.version >= 38) which I don't want to have in the code. Thus I'd postpone this some time until version 38 is out and has enough traction.
